simplify ci.yaml to single runner with cross-compile; add release creation and artifact push #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation and artifact push Signed-off-by: Avi Deitcher <avi@deitcher.net>
vidas
approved these changes
May 27, 2025
|
|
||
| $(CONTROLLER): $(BINDIR) | ||
| @go build -o $@ ./cmd/ | ||
| $(CONTROLLER_GENERIC)-%: $(BINDIR) |
Member
There was a problem hiding this comment.
Unrelated to this change, but this target should be either phony (to use make as a task runner) or list source dependencies explicitly (to use make as a build system). I'd go with first, as go build is smart enough already.
Currently it fails to recompile when there are changes.
Member
Author
There was a problem hiding this comment.
We can add it as a future small PR, since you already approved this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58