[DRAFT][DO NOT MERGE] Add helpers #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| gem 'rake', '~> 12.0' | ||
| gem 'rspec', '~> 3.0' | ||
| gem 'activesupport' |
| uri = URI(auth_endpoint) | ||
| req = Net::HTTP::Post.new(uri, 'Content-Type' => 'application/json') | ||
| req.body = creds.to_json | ||
| api_execute(:post, uri, creds) |
Contributor
There was a problem hiding this comment.
It would be great to add error handling for requests. No errors are raised if the server is unavailable or the credentials are wrong. I'm just getting this unclear error when running specs.
| uri = URI(auth_endpoint) | ||
| req = Net::HTTP::Post.new(uri, 'Content-Type' => 'application/json') | ||
| req.body = creds.to_json | ||
| api_execute(:post, uri, creds) |
Contributor
There was a problem hiding this comment.
Also I'm getting stack level too deep error in this spec spec/rspec/llama/api_client_spec.rb:15
| module Helpers | ||
| module Executor | ||
|
|
||
| def execute_test_run(prompt_id: nil, assertion_id: nil, model_version_id: nil) |
Contributor
There was a problem hiding this comment.
Please update helpers_spec
| # Enable flags like --only-failures and --next-failure | ||
| config.api_endpoint = 'https://api.example.com' | ||
| config.auth_endpoint = 'https://api.example.com/authenticate' | ||
| config.auth_endpoint = 'https://api.example.com/users/sign_in' |
Contributor
There was a problem hiding this comment.
I think this spec is useless spec/rspec/llama/configuration_spec.rb, it fails when I change credentials or set custom endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.