Impl read state

[jsoncitron]

Add Support for Read State

Closes #1453
Closes #1501

[TheDevYellowy]

Just a quick heads up, the new X-Super-Properties haven't been added to the Options.js file Disregard this, I didn't read the changes in the latest update of the package.

[ptraced]

Just a FYI the correct useragent is Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36 for the options your using in X-Super lol not electron

{"os":"Windows","browser":"Chrome","device":"","system_locale":"en-US","has_client_mods":false,"browser_user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36","browser_version":"135.0.0.0","os_version":"10","referrer":"","referring_domain":"","referrer_current":"https://www.google.com/","referring_domain_current":"www.google.com","search_engine_current":"google","release_channel":"stable","client_build_number":386432,"client_event_source":null}

example of a real user

[jsoncitron]

Just a FYI the correct useragent is Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36 for the options your using in X-Super lol not electron

{"os":"Windows","browser":"Chrome","device":"","system_locale":"en-US","has_client_mods":false,"browser_user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36","browser_version":"135.0.0.0","os_version":"10","referrer":"","referring_domain":"","referrer_current":"https://www.google.com/","referring_domain_current":"www.google.com","search_engine_current":"google","release_channel":"stable","client_build_number":386432,"client_event_source":null}

example of a real user

Thanks For heads Up!

[ufukdev]

@jsoncitron do you need tokens for test?

[jsoncitron]

@jsoncitron do you need tokens for test?

No

[ufukdev]

@jsoncitron Any idea when this PR will get merged?

[jsoncitron]

@jsoncitron Any idea when this PR will get merged?

Ask @aiko-chan-ai

[aiko-chan-ai]

@jsoncitron Any idea when this PR will get merged?

Ask @aiko-chan-ai

As I mentioned in my profile, I'm not very active on GitHub at the moment.
And since this is a large PR, I'll need some time to review the code (I'm not certain, but I'll try to provide feedback within a few days).

[ufukdev]

@aiko-chan-ai Thank you for your response. I would really appreciate it if we could move the process forward a bit earlier.

[aiko-chan-ai]

I would like your answers to these questions

[aiko-chan-ai]

No Just make it GuildSettings

Because this class also manages both DM channels and Group DM channels, labeling it as GuildSetting would be inappropriate.

Yes but also guilds

Then it should be renamed, because "GuildSetting" is misleading — there are no actual settings here, it's all just server notifications

[jsoncitron]

I would like your answers to these questions

1. state.client.notification_settings points to user_guild_settings entry whose guild_id is null
2. Perhaps I Should call it "UserGuildSettings" instead then? Dont wanna to name it NotificationSettings bcz it clashes with NotificationSettings (notification_settings in READY)

Then it should be renamed, because "GuildSetting" is misleading — there are no actual settings here, it's all just server notifications

Read point 2

[ptraced]

C:\Users\Ascent\Desktop\discord.js-selfbot-v13-read-state\src\client\actions\MessageCreate.js
51:13 error Blocks are nested too deeply (5). Maximum allowed is 4 max-depth
52:13 error Blocks are nested too deeply (5). Maximum allowed is 4 max-depth

C:\Users\Ascent\Desktop\discord.js-selfbot-v13-read-state\src\managers\ReadStateManager.js
55:3 error Missing JSDoc @returns for function valid-jsdoc
109:20 error 'badgeCount' is not defined no-undef
119:3 error Missing JSDoc for parameter 'readStates' valid-jsdoc
213:24 error 'entityId' is defined but never used no-unused-vars
218:47 error 'entity' is not defined no-undef

C:\Users\Ascent\Desktop\discord.js-selfbot-v13-read-state\src\structures\ReadState.js
79:98 error Insert ⏎····· prettier/prettier

Doesn't even build btw @aiko-chan-ai

[aiko-chan-ai]

I would like your answers to these questions

1. state.client.notification_settings points to user_guild_settings entry whose guild_id is null
2. Perhaps I Should call it "UserGuildSettings" instead then? Dont wanna to name it NotificationSettings bcz it clashes with NotificationSettings (notification_settings in READY)

Then it should be renamed, because "GuildSetting" is misleading — there are no actual settings here, it's all just server notifications

Read point 2

So should you make something similar for DM Channels and GDM Channels? Also, you shouldn't set GuildSettings as a prop on the Client; instead, you should pass it into the GuildManager

[jsoncitron]

I would like your answers to these questions

1. state.client.notification_settings points to user_guild_settings entry whose guild_id is null
2. Perhaps I Should call it "UserGuildSettings" instead then? Dont wanna to name it NotificationSettings bcz it clashes with NotificationSettings (notification_settings in READY)

Then it should be renamed, because "GuildSetting" is misleading — there are no actual settings here, it's all just server notifications

Read point 2

So should you make something similar for DM Channels and GDM Channels? Also, you shouldn't set GuildSettings as a prop on the Client; instead, you should pass it into the GuildManager

SO IS there a way to name it so it doesnt clash with NotificationSettings ? Or Call it UserNotificationSettings instead

[aiko-chan-ai]

Do it your way 😎