-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor ClientRequest #11012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dreamsorcerer
wants to merge
76
commits into
master
Choose a base branch
from
clientrequest-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,817
−1,611
Open
Refactor ClientRequest #11012
Changes from 74 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
18564e9
Refactor ClientRequest
Dreamsorcerer f4d733f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 22d724a
Add kwargs
Dreamsorcerer 6fa8996
Merge branch 'clientrequest-refactor' of github.com:aio-libs/aiohttp …
Dreamsorcerer 8257048
Tweaks
Dreamsorcerer 7171e0a
Fix
Dreamsorcerer 9023653
Fix
Dreamsorcerer 6a1e81a
Fix benchmarks
Dreamsorcerer ef47363
Fix benchmarks
Dreamsorcerer 477d52d
Remove unneeded code
Dreamsorcerer 8fbac96
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb5f104
Fix
Dreamsorcerer 3820c39
Merge branch 'clientrequest-refactor' of github.com:aio-libs/aiohttp …
Dreamsorcerer 2559a0b
Merge branch 'master' into clientrequest-refactor
Dreamsorcerer 19dfe3a
Readd shortcut
Dreamsorcerer 580387b
Merge branch 'clientrequest-refactor' of github.com:aio-libs/aiohttp …
Dreamsorcerer 0cdf184
Tweaks
Dreamsorcerer ecc6dac
Merge branch 'master' into clientrequest-refactor
Dreamsorcerer c338a6d
Reduce diff
Dreamsorcerer b12ebae
Update client_reqrep.py
Dreamsorcerer b95493c
Update client_reqrep.py
Dreamsorcerer e4cc1dc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] be3299c
Fixes
Dreamsorcerer ca57cab
Fixes
Dreamsorcerer 4b93f0f
Create fixture
Dreamsorcerer 7666c36
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0332916
Fixes
Dreamsorcerer 500a4fb
Fixes
Dreamsorcerer f4ebcb7
Fixes
Dreamsorcerer 15a0fa8
Fixes
Dreamsorcerer deec35d
Fixes
Dreamsorcerer 8f462a2
Fixes
Dreamsorcerer c20f2ce
Fixes
Dreamsorcerer 28f1369
Fixes
Dreamsorcerer 77137bf
Update conftest.py
Dreamsorcerer 23029d2
Update conftest.py
Dreamsorcerer 0a5651b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 03e5abf
Update client_reqrep.py
Dreamsorcerer 39aa3f2
Update test_client_request.py
Dreamsorcerer e4f0eb4
Update test_client_request.py
Dreamsorcerer da1e507
Update client_reqrep.py
Dreamsorcerer 2989a2c
Update test_client_request.py
Dreamsorcerer 8c95f70
Update test_client_request.py
Dreamsorcerer 6f5011e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ddb67a5
Merge branch 'master' into clientrequest-refactor
Dreamsorcerer a823273
Update client_reqrep.py
Dreamsorcerer ddc69ad
Update client_reqrep.py
Dreamsorcerer 13db9c9
Update client_reqrep.py
Dreamsorcerer dd207ec
Fixes
Dreamsorcerer d1aadac
Fixes
Dreamsorcerer 399ad18
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 52e3776
Fixes
Dreamsorcerer 7c7af5d
Merge branch 'clientrequest-refactor' of github.com:aio-libs/aiohttp …
Dreamsorcerer 583eca6
Fixes
Dreamsorcerer 1c82693
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 54e9ee7
Update test_proxy.py
Dreamsorcerer 89f6de2
Merge branch 'master' into clientrequest-refactor
Dreamsorcerer 4c8df69
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 57e84cc
Fixes
Dreamsorcerer 861fa1a
Fixes
Dreamsorcerer 4895d27
Fixes
Dreamsorcerer 3bb91ca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e929ff5
Fixes
Dreamsorcerer 6145b46
Merge branch 'clientrequest-refactor' of github.com:aio-libs/aiohttp …
Dreamsorcerer 157be4d
Fixes
Dreamsorcerer 1d542e6
Fixes
Dreamsorcerer 6855d0a
Fixes
Dreamsorcerer 61f9aa7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb9ec6e
Fixes
Dreamsorcerer f1549ea
Fixes
Dreamsorcerer c392b49
Create 11012.breaking.rst
Dreamsorcerer f19ab2a
solve one perf regression
bdraco 9eceeef
build request info once
bdraco 238096f
lazy construct RequestInfo
bdraco 5780c0a
Update CHANGES/11012.breaking.rst
Dreamsorcerer fec5fef
str annotations
Dreamsorcerer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Refactored ``ClientRequest`` class. This simplifies a lot of code and improves our type | ||
| checking accuracy. It also better aligns public/private attributes with what we expect | ||
| developers to access safely from a client middleware. | ||
|
|
||
| If code subclasses ``ClientRequest``, it is likely that the subclass will need tweaking | ||
| to be compatible with the new version. | ||
|
|
||
| -- by :user:`Dreamsorcerer`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.