Fix build and cmake warnings #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that cmake plans to drop backward compatibility for cmake of version 3.5 in future realeases, so one of solutions is to bump minimum cmake version. To be precise, fixes this output. CMake Deprecation Warning at FactoryMethod/cpp-source/CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake. Update the VERSION argument <min> value or use a ...<max> suffix to tell CMake that the project does not need compatibility with older versions. Same descriptions excluded for conciseness. CMake Deprecation Warning at AbstractFactory/cpp-source/CMakeLists.txt:1 (cmake_minimum_required): CMake Deprecation Warning at AbstractFactory/cpp-source/serializers/CMakeLists.txt:1 (cmake_minimum_required): CMake Deprecation Warning at AbstractFactory/cpp-source/rooms/CMakeLists.txt:1 (cmake_minimum_required): CMake Deprecation Warning at AbstractFactory/cpp-source/factories/CMakeLists.txt:1 (cmake_minimum_required): CMake Deprecation Warning at Decorator/cpp-source/CMakeLists.txt:1 (cmake_minimum_required): CMake Deprecation Warning at Facade/cpp-source/CMakeLists.txt:1 (cmake_minimum_required):
akhtyamovpavel
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.