This repository was archived by the owner on Apr 7, 2025. It is now read-only.
Update README.md for logging & tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove comment on logging as it doesn't provide value IMO Remove comment on tests are we are actively looking for good tests. Stating that the tests are in the category of nice to have doesn't feel fair towards the candidate.
martijnmol
requested review from
CyrilleThibout-Albelli,
bengelsdorff,
rheusinkveld and
wcrooy
rheusinkveld
approved these changes
Feb 15, 2022
bengelsdorff
approved these changes
Feb 15, 2022
|
Often I also get questions regarding which database to use. Perhaps we can explain a bit about that as well. |
wcrooy
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove comment on logging as it doesn't provide value IMO
Remove comment on tests are we are actively looking for good tests. Stating that the tests are in the category of nice to have doesn't feel fair towards the candidate.