Skip to content

Conversation

Alexhuszagh
Copy link
Contributor

Related to #16.

Add in benchmarks to fast-float-rust
This patches a lot of the wrappers in `AsciiStr` being marked as safe but not being safe except within the context, using raw pointer dereferences without local bounds checks.

This is extensively documented in aldanor#37:
    aldanor#37

`AsciiStr` has been re-written as a result, and unsafe functions marked as safe have been either converted to safe variants where the compiled checks can be ellided or marked as unsafe so the caller knows to upholds the safety invariants.
Remove all non-local unsafety.
Ensure checked indexing is used for the power-of-5 table lookup.
Add miri and fuzz targets to our CI.
Fix the `MAX` to `max_value()` for ancient rustc support.
@Alexhuszagh
Copy link
Contributor Author

This is incomplete since it only tests Intel, and no other architectures/OSes. Due to the build difficulties with abseil and minor changes in fast_float making our benchmark code not compile, this will be difficult to adopt in CI without some larger changes.

@Alexhuszagh Alexhuszagh deleted the benches branch December 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant