V0: Merge AutomationDirect repository into alexrudd2 repository #88
Conversation
- the setters and getters for missing data types have been filled in - serial support is being implemented, but will need a lot of testing
- debug statements have been placed for further developers / users who need to figure out where their code is going wrong. - ruff linting done for too-long lines and unused parameters
previous commit was actually not the comment fixes. that was fixing the 21-36 issue. my bad
i am going to get rid of all the binarypayloaddecoders first
|
Nice to meet you @andygarcha-adc! I was expecting you at some point. Conor had told me about the intern plans but I wasn't able to find your repo (until now). :) You can email me at my git commiter address if you'd like. Your changes overall look good and I intend to get them merged. I think it'll take some time working through things together. Welcome to the unglamorous part of software development 😆 This is a big pull request with lots of changes. It's often better to do one smaller, targeted pull request per change. Are you familiar with |
|
Hey Alex, I tried to email you earlier but I'm now seeing it didn't go through. I'll copy it below: Hey Alex, This is Andy from ADC. I'm totally good to break it all into separate PRs (which might take some work, my commit history is a little bit everywhere). Thank you for responding, and I hope my work is of use to you! I'll get started on breaking those up and reach out to you when I have something to show of it. Have a great weekend, |
andygarcha-adc
changed the title
Hi Alex, Hope you're doing well! I'm an intern at AutomationDirect this summer and I was tasked to work on this library. We've created our own fork but I see that you are still continuing to do maintenance so we would like to merge our work into yours. Please take a look and let me know if you see anything that doesn't fit.
XDandYDdatatypesX21-X36andY21-Y36BinaryPayloadDecoder(as I see you've already done) in favor ofclient.convert_from_registers()SC50andSC51from writable addresses (this is a bug in the Click software, these registers should not be writable)CTDdatatypes.docs.md