Skip to content

Add X/Y support for registers 21-36 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add X/Y support for registers 21-36 #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0f37d
Add read support X21-X36
andygarcha-adc Aug 12, 2025
85c4eb4
Add read support for Y21-Y36
andygarcha-adc Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clickplc/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ async def _get_x(self, start: int, end: int | None) -> dict:
a number of addresses not divisible by 8, it will have extra data. The
extra data here is discarded before returning.
"""
if start % 100 == 0 or start % 100 > 16:
if (start % 100 == 0 or start % 100 > 16) and start not in range(21, 37):
raise ValueError('X start address must be *01-*16.')
if start < 1 or start > 816:
raise ValueError('X start address must be in [001, 816].')
Expand All @@ -180,7 +180,7 @@ async def _get_x(self, start: int, end: int | None) -> dict:
coils = await self.read_coils(start_coil, 1)
return coils.bits[0]

if end % 100 == 0 or end % 100 > 16:
if end % 100 == 0 or end % 100 > 16 and start not in range(21, 37):
raise ValueError('X end address must be *01-*16.')
if end < 1 or end > 816:
raise ValueError('X end address must be in [001, 816].')
Expand Down Expand Up @@ -219,7 +219,7 @@ async def _get_y(self, start: int, end: int | None) -> dict:
a number of addresses not divisible by 8, it will have extra data. The
extra data here is discarded before returning.
"""
if start % 100 == 0 or start % 100 > 16:
if start % 100 == 0 or start % 100 > 16 and start not in range(21, 37):
raise ValueError('Y start address must be *01-*16.')
if start < 1 or start > 816:
raise ValueError('Y start address must be in [001, 816].')
Expand All @@ -229,7 +229,7 @@ async def _get_y(self, start: int, end: int | None) -> dict:
coils = await self.read_coils(start_coil, 1)
return coils.bits[0]

if end % 100 == 0 or end % 100 > 16:
if end % 100 == 0 or end % 100 > 16 and start not in range(21, 37):
raise ValueError('Y end address must be *01-*16.')
if end < 1 or end > 816:
raise ValueError('Y end address must be in [001, 816].')
Expand Down
Loading