Update k8s meta with specific relation type #2224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
requested changes
May 20, 2025
| @@ -241,8 +241,9 @@ func (m *metaCollector) handleAddOrUpdate(event *k8smeta.K8sMetaEvent) { | |||
| logs := processor(event.Object, "Update") | |||
| for _, log := range logs { | |||
| m.send(log, isEntity(event.Object.ResourceType)) | |||
| if isEntity(event.Object.ResourceType) && canClusterLinkDirectly(event.Object.ResourceType, m.serviceK8sMeta) { | |||
| link := m.generateEntityClusterLink(log) | |||
| canClusterLinkDirectly, relationType := canClusterLinkDirectly(event.Object.ResourceType, m.serviceK8sMeta) | |||
| link := m.generateEntityClusterLink(log) | ||
| canClusterLinkDirectly, relationType := canClusterLinkDirectly(event.Object.ResourceType, m.serviceK8sMeta) | ||
| if isEntity(event.Object.ResourceType) && canClusterLinkDirectly { | ||
| link := m.generateEntityClusterLink(log, relationType) |
There was a problem hiding this comment.
其他地方好像都叫linkType，不叫relationType
There was a problem hiding this comment.
这个定义就是relation type，为了清晰，此处改成linkRelationType
| @@ -417,8 +419,11 @@ func (m *metaCollector) generateEntityClusterLink(entityEvent models.PipelineEve | |||
| log.Contents.Add(entityLinkDestDomainFieldName, m.serviceK8sMeta.domain) | |||
| log.Contents.Add(entityLinkDestEntityTypeFieldName, content.Get(entityTypeFieldName)) | |||
| log.Contents.Add(entityLinkDestEntityIDFieldName, content.Get(entityIDFieldName)) | |||
|
|
|||
| log.Contents.Add(entityLinkRelationTypeFieldName, "runs") | |||
| if relationType != "" { | |||
There was a problem hiding this comment.
这里是不是保留空字符串就行了，其他关系也没配默认值
Abingcbc
approved these changes
May 20, 2025
messixukejia
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass relationtype to cluster-entity link by entity type
原 ： 对于cluster到Namespace、Node的link的关系类型，默认runs，参数配置没有生效
现 : 基于具体的参数配置（Cluster2Namespace等） 进行关系类型设定