fix: improve the judgment of the legitimacy of prometheus metrics #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linrunqi08
reviewed
May 28, 2025
| @@ -104,7 +104,7 @@ bool IsValidMetric(const StringView& line) { | |||
| if (c == ' ' || c == '\t') { | |||
| continue; | |||
| } | |||
| if (c == '#') { | |||
| if (!((c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || c == '_' || c == ':')) { | |||
There was a problem hiding this comment.
| @@ -101,6 +101,8 @@ void ScrapeScheduler::OnMetricResult(HttpResponse& response, uint64_t) { | |||
| streamScraper->mStreamIndex++; | |||
| if (upState) { | |||
| streamScraper->FlushCache(); | |||
| } else { | |||
| streamScraper->ClearEventGroup(); | |||
There was a problem hiding this comment.
这里为啥clear？ clear之后，SendMetrics，里面不都是空数据吗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrape request returns "404", it may be considered as a metric. Improve the logic so we can get the correct metrics count.