[struct_pack] use unsigned long long integer literal to silence gcc warnings #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses the same issue as #952, but provides a more comprehensive commit message that explains the rationale behind the change. I've created this separate PR to ensure the change is properly documented with the complete context and justification. |
|
Please format the code. |
|
for detail, goto summary download Artifacts |
tchaikov
force-pushed
the
silence-overflow-warnings
branch
from
3ac5d14 to
2435541
Compare
|
for detail, goto summary download Artifacts |
…arnings
when building the tree using GCC-15, we have following warnings:
```
/home/kefu/dev/yalantinglibs/include/ylt/struct_pack/type_calculate.hpp: In function ‘constexpr decltype(auto) struct_pack::detail::get_size_literal()’:
/home/kefu/dev/yalantinglibs/include/ylt/struct_pack/type_calculate.hpp:64:58: warning: integer overflow in expression of type ‘int’ results in ‘-1321368961’ [-Woverflow]
64 | static_cast<char>(size / (127 * 127 * 127 * 127 * 127) + 129)}};
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
```
because `127` is an `int`, if the expression evaluates to an constant
with cannot be represented with `int`, the compiler warns. in order to
silence the warnings, let's use the `ull` prefix.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
silence-overflow-warnings
branch
from
2435541 to
4c8afeb
Compare
|
changlog
|
|
LGTM |
|
for detail, goto summary download Artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building the tree using GCC-15, we have following warnings:
because
127is anint, if the expression evaluates to an constant with cannot be represented withint, the compiler warns. in order to silence the warnings, let's use theullprefix.Why
What is changing
Example