feat: add helper EvmFactory type that modifies the PrecompilesMap #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested changes
Jul 19, 2025
Member
There was a problem hiding this comment.
let's move this to crates/evm/src/evm.rs and add a helper
fn with_modified_precompiles<F>(self, f: F) -> EvmFactoryWith<Self, F>
where
F: Fn(&mut PrecompilesMap, Self::Spec)to EvmFactoryExt here:
Line 240 in fb075bf
crates/evm/src/eth/mod.rs
Outdated
| } | ||
|
|
||
| /// Trait for modifying precompiles based on spec ID. | ||
| pub trait PrecompileModifies<SpecId> { |
Member
There was a problem hiding this comment.
let's add a blanket impl for Fn(&mut PrecompilesMap, SpecId)
Member
|
I'm also wondering if we shuld have a more general wdyt @mattsse |
Member
|
@klkvr should this then be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #119
Solution
PR Checklist