Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Conversation

@AnandHemachandran
Copy link

This commit shall provide you a feature to get the WIFI SSiD in windows inorder to send the request to the server.

Copy link
Contributor

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anand,

Thanks for taking initiative having Windows support,

I have created a issue for tracking the progress at #2

# get list of wifi ssid's
wifi_ssid_list = get_wifi_list()
# get wifi's ssid if the platform is windows
if _platform == "win32":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking how about if we add over get_wifi_list():(

def get_wifi_list():

instead of modifying here so we can add another condition like

if _platform == "win32":
      .
      .

so it will be looking uniform

import json

import requests
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why there was a use to import OS now?

import json

import requests
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import os

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants