Skip to content

Conversation

he1senbrg
Copy link
Member

@he1senbrg he1senbrg commented May 5, 2025

closes #27

let end_date = date
.with_day(1)
.unwrap()
.with_month(date.month() + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break when the date is in December?


let end_date = date
.with_day(1)
.unwrap()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use unwraps in the API, makes it harder to debug.

@@ -58,3 +58,11 @@ pub struct AttendanceWithMember {
pub year: i32,
pub group_id: i32,
}

#[derive(SimpleObject, FromRow)]
pub struct AbsentsWithMember {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more appropriate name would be MemberWithAbsence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants