add MAX17616/MAX17616A driver #2949
Open
+218
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseerp
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
Add Analog Devices MAX17616/MAX17616A Current-Limiter with Overvoltage/Surge, Undervoltage, Reverse Polarity, Loss of Ground Protection with PMBus Interface. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add support for the Analog Devices MAX17616/MAX17616A Current-Limiter with Overvoltage/Surge, Undervoltage, Reverse Polarity, Loss of Ground Protection with PMBus Interface. The PMBus interface allows monitoring of input/output voltages, output current and temperature. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
kseerp
force-pushed
the
dev-max17616
branch
from
c3062cc to
4b58025
Compare
nunojsa
reviewed
Sep 23, 2025
| compatible: | ||
| enum: | ||
| - adi,max17616 | ||
| - adi,max17616a |
There was a problem hiding this comment.
Why 2 compatibles? What's the difference between the variants? It seems that in terms of SW there's none (apart from the name)...
| return dev_err_probe(dev, ret, "Failed to read MFR_MODEL\n"); | ||
|
|
||
| if ((strncmp(buf + 1, "MAX17616", 8) && strncmp(buf + 1, "MAX17616A", 9))) | ||
| return dev_err_probe(dev, -ENODEV, "Unsupported device\n"); |
There was a problem hiding this comment.
Do we really want to have the above? And I guess that if ((strncmp(buf + 1, "MAX17616", 8)) should be enough, no? AFAICT, the two variants are pretty much compatible?
| static struct i2c_driver max17616_driver = { | ||
| .driver = { | ||
| .name = "max17616", | ||
| .of_match_table = of_match_ptr(max17616_of_match), |
There was a problem hiding this comment.
please drop of_match_ptr()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add MAX17616/MAX17616A Current-Limiter with Overvoltage/Surge, Undervoltage, Reverse Polarity, Loss of Ground Protection with PMBus Interface
PR Type
PR Checklist