Adding driver support for adpm12100, adpm12130, and adpm12200 #2956
Conversation
actorreno
force-pushed
the
staging_adpm12xx0_support
branch
from
21ef46a to
ef98727
Compare
actorreno
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
| .format[PSC_CURRENT_OUT] = direct, | ||
| .format[PSC_TEMPERATURE] = direct, | ||
| .m[PSC_VOLTAGE_IN] = 1, | ||
| .m[PSC_VOLTAGE_IN] = 125, |
There was a problem hiding this comment.
Hmm this is questionable. What about devices running old firmware? Do we have any way (from HW registers) to get this info from the device and tweak this at runtime depending on the running FW?
Also, take care about the git subject. Not according to the subsystem style
There was a problem hiding this comment.
updated git subject for commit 1
I am aware of the practice of supporting released products but I was told this hasn't actually released and will release with the latest FW I based this fix on.
short history:
they planned to release the driver+part at the same time. I was allowed to publicly push this even if that specific time it wasn't public yet. I even gave the upstream maintainers a copy of the datasheet to convince them to accept the patch of an unreleased part (with permission from adpm12160 owners)
I suppose this got delayed until eventually updating the fw from fw12 to fw14
I believe this kind of permanent fix is ok.
There was a problem hiding this comment.
Fine by me, but you need to send these patches upstream and explain the change with what you just told me and I would also recommend to add a link (in your cover letter) to the patches where you first added the drivers so they can remember it was not yet a public part.
There was a problem hiding this comment.
will apply suggestions to cover letter
btw is this good/ok for upstream?
There was a problem hiding this comment.
"This driver has permission to be released ahead of the part."
Not sure if the above adds much. But sure, go ahead and send it upstream
adpm12160 is a dc-dc power module. The firmware was updated and the coeeficients in the pmbus_driver_info needs to be updated. Since the part has not yet released with older FW, this permanent change to reflect the latest should be ok. This driver has permission to be released ahead of the part. Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
actorreno
force-pushed
the
staging_adpm12xx0_support
branch
2 times, most recently
from
ed54de2 to
e85dc71
Compare
ADPM12200 is a quarter brick DC/DC Power Module. It is a high power non-isolated converter capable of delivering regulated 12V with continuous power level of 2000W. Uses PMBus. Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
actorreno
force-pushed
the
staging_adpm12xx0_support
branch
from
e85dc71 to
d4d8279
Compare
|
v2: trimmed the PR, apparently adpm12100 and adpm12130 are still finalizing some inductor and hence samples are not final and may change. this PR now just contains the adpm12160 firmware update and adding support to adpm12200. |
ADPM12160 is a quarter brick DC/DC Power Module. It is a high power non-isolated converter capable of delivering a fully regulated 12V, with continuous power level of 1600W with peak power at 2400W for a limited time. Uses PMBus Configuration.
PR Description
Bug: In the voltage m,b,r pmbus info initially 1,0,0, must be 1,0,3 since it is in millivolts
FW14 update: m != 1 updated to m=0.125. To be an integer m=125, r = -3.
The two changes combined results in m,b,r = 125,0,0. Current also has some changes.
PR Type
PR Checklist