fix(nf): correct the index file path for SSR builds in the updateIndexHtml util #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rainerhahnekamp @manfredsteyer hi, I attempted to manage the CI, but it failed. The branch is forked from angular-architects:main, so there shouldn’t be any issues with hash checking. |
|
@vrady just to be sure. You are having issues with our CI, right? |
|
@rainerhahnekamp yes, |
manfredsteyer
force-pushed
the
main
branch
4 times, most recently
from
93c1fc5 to
18c2874
Compare
|
Hi @vrady, is this still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular CLI generates an index.csr.html file for SSR builds, causing the updateIndexHtml function to fail since it looks for an ‘index.html’ file. To ensure the function works correctly, a check for the SSR option needs to be added to the utility.