chore: improve code error message for missing Angular project in angu… #923
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. Perhaps we should write angular.json or project.json because Nx uses the latter one. |
Aukevanoost
reviewed
Oct 9, 2025
|
|
||
| if (!projectConfig) { | ||
| throw new Error(`Project ${projectName} not found!`); | ||
| throw new Error(`Project ${projectName} not found in angular.json.`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Project ${projectName} not found in angular.json.`); | |
| throw new Error(`Project ${projectName} not found in Angular workspace (angular.json or project.json).`); |
|
|
||
| if (!projectConfig) { | ||
| throw new Error(`Project ${projectName} not found!`); | ||
| throw new Error(`Project ${projectName} not found in angular.json.`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Project ${projectName} not found in angular.json.`); | |
| throw new Error(`Project ${projectName} not found in Angular workspace (angular.json or project.json).`); |
|
|
||
| if (!projectConfig) { | ||
| throw new Error(`Project ${projectName} not found!`); | ||
| throw new Error(`Project ${projectName} not found in angular.json.`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Project ${projectName} not found in angular.json.`); | |
| throw new Error(`Project ${projectName} not found in Angular workspace (angular.json or project.json).`); |
|
|
||
| if (!projectConfig) { | ||
| throw new Error(`Project ${projectName} not found!`); | ||
| throw new Error(`Project ${projectName} not found in angular.json.`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Project ${projectName} not found in angular.json.`); | |
| throw new Error(`Project ${projectName} not found in Angular workspace (angular.json or project.json).`); |
|
|
||
| if (!projectConfig) { | ||
| throw new Error(`Project ${projectName} not found!`); | ||
| throw new Error(`Project ${projectName} not found in angular.json.`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Project ${projectName} not found in angular.json.`); | |
| throw new Error(`Project ${projectName} not found in Angular workspace (angular.json or project.json).`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated all instances of:
to
because my team and I (due to our own oversight in not reading the documentation) had difficulty, as we thought we needed to use the property name in webconfig instead of the project name.
So, I’m suggesting this change to make the error message more descriptive, which could save time for others in the future (if you agree).