Skip to content

Migrate to new JS interop and web package. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 24, 2025
Merged

Migrate to new JS interop and web package. #82

merged 19 commits into from
Jun 24, 2025

Conversation

@ykmnkmi
Copy link

@ykmnkmi ykmnkmi commented Apr 22, 2025

WIP.

@ykmnkmi
Copy link
Author

ykmnkmi commented May 5, 2025 •
edited
Loading

@GZGavinZhao all done. Note: ViewChild and other queries using read checks types against JSObject, because the extension type is replaced with the real type, from @ViewChild('label', read: Element) to @ViewChild('label', read: JSObject).

@ykmnkmi ykmnkmi marked this pull request as ready for review May 5, 2025 08:54
@GZGavinZhao
Copy link

GZGavinZhao commented May 5, 2025

Thanks a lot! Will look this weekend.

@ykmnkmi
Copy link
Author

ykmnkmi commented Jun 19, 2025

Any news?

@insinfo
Copy link

insinfo commented Jun 21, 2025

@ykmnkmi Congratulations on the work, any news on when it will be merged?

GZGavinZhao
GZGavinZhao approved these changes Jun 22, 2025
View reviewed changes
Copy link

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thank you so much for the herculean effort! I've been working and it was quite hard to look through such a humongous PR.

@GZGavinZhao
Copy link

GZGavinZhao commented Jun 22, 2025

If CI check passes again then I'll merge.

ykmnkmi added 18 commits June 21, 2025 21:05
@ykmnkmi @GZGavinZhao
Init: ngcompiler, ngdart, ngtest.
efd5a05 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Update ngcompiler.
40db1ce 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Fix ngdart.
c1063ff 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Migrate ngrouter.
3992079 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Migrate ngforms.
81e9ecf 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Update ngcompiler, ngdart, ngforms.
527e0ef 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Migrating _tests. Update ngdart.
047ff40 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Update ngcompile and ngdart.
0527aa8 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Remove the dev SDK version from the mono_repo config.
2733b05 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Delete conflicting outputs.
e3e1c1b 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Revert event type.
c6b5211 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Add dart2wasm test compiler.
81b5cbf 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Fixes.
7826d2c 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Format.
72d6c00 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Fix *Query(..., read: Element).
8787fa0 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Update Element.attributes tests.
0e6d5ee 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Fix sanitization.
210195a 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@ykmnkmi @GZGavinZhao
Fix last failing _tests.
5538667 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@GZGavinZhao
Copy link

GZGavinZhao commented Jun 23, 2025

errr looks like build_runner_core v9 broke stuff... I'll take a look tomorrow.

@GZGavinZhao
Downgrade build_runner_core to <9.0.0
7ec6520 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
@GZGavinZhao GZGavinZhao merged commit 69426d3 into angulardart-community:master Jun 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GZGavinZhao GZGavinZhao GZGavinZhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ykmnkmi @GZGavinZhao @insinfo