Namadillo: Optimistically updating staking rewards balance #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
approved these changes
Sep 19, 2024
| }; | ||
|
|
||
| useTransactionEventListener("Bond.Success", onBalanceUpdate); | ||
| useTransactionEventListener("Unbond.Success", onBalanceUpdate); | ||
| useTransactionEventListener("Withdraw.Success", onBalanceUpdate); | ||
| useTransactionEventListener("Redelegate.Success", onBalanceUpdate); | ||
| useTransactionEventListener("ClaimRewards.Success", onBalanceUpdate); | ||
| useTransactionEventListener("ClaimRewards.Success", onBalanceUpdate, [ | ||
| account, |
There was a problem hiding this comment.
nice idea! I'm asking myself if this object changes for whatever reason and if we should use account?.address instead
| @@ -159,3 +160,7 @@ export const createClaimAndStakeTx = async ( | |||
| account.address | |||
| ); | |||
| }; | |||
|
|
|||
| export const clearClaimRewards = (accountAddress: string): void => { | |||
| queryClient.setQueryData(["claim-rewards", accountAddress], () => ({})); | |||
There was a problem hiding this comment.
Did you try this as invalidateQueries https://tanstack.com/query/latest/docs/framework/react/guides/query-invalidation ? I think this is the "correct way" to clear queries for react-query
There was a problem hiding this comment.
Actually not. I'm overriding the result of the claim-rewards query, so no rewards are available :) . But maybe I can be more explicit on this. Will make a small change before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you claim rewards, the indexer will need to wait for the next block to sync the new amount. This process might take a few seconds, depending on network configuration. This PR sets the available rewards balance to zero as soon as the claim rewards success event gets fired.