feat: Keychain - Add exclusion list to Keychain manifest #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
force-pushed
the
feat/keychain-blacklist-matches
branch
from
2aa4959 to
b0922ee
Compare
jurevans
force-pushed
the
feat/keychain-blacklist-matches
branch
from
b0922ee to
0e3c984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces blacklisted matches to prevent content script injection on potentially malicious domains.
TODO Finish adding any missing patterns that could be mistaken for
namadillo.app, and add any additional blacklisted patterns here.Generated Chrome Manifest
example snippet
{ "name": "Namada Keychain", "description": "The Namada Keychain manages a user's wallet for the Namada ecosystem.", "version": "0.6.0", "manifest_version": 3, "background": { "service_worker": "background.namada.js", "type": "module" }, "content_scripts": [ { "matches": [ "<all_urls>" ], "js": [ "content.namada.js" ], "exclude_glob": [ "*://namadill0.app/*", "*://namadi1l0.app/*", "*://namadi1lo.app/*", "*://namadi110.app/*", "*://namadi11o.app/*", "*://namad1llo.app/*", "*://namad1ll0.app/*", "*://namad11lo.app/*", "*://namad111o.app/*", "*://namad1110.app/*", "*://nammadillo.app/*", "*://nammad1llo.app/*", "*://nammadi1lo.app/*", "*://nammadi11o.app/*", "*://nammadi110.app/*", "*://nammadill0.app/*", "*://nammadi1l0.app/*", "*://nammad1110.app/*" ] } ], }Generated Firefox Manifest
example snippet
{ "name": "Namada Keychain", "description": "The Namada Keychain manages a user's wallet for the Namada ecosystem.", "version": "0.6.0", "manifest_version": 2, "browser_action": { "default_popup": "popup.html", "default_title": "Namada Keychain" }, "background": { "scripts": [ "background.namada.js" ], "persistent": true }, "permissions": [ "storage" ], "content_scripts": [ { "matches": [ "<all_urls>" ], "js": [ "content.namada.js" ], "run_at": "document_start", "all_frames": true, "exclude_glob": [ "*://namadill0.app/*", "*://namadi1l0.app/*", "*://namadi1lo.app/*", "*://namadi110.app/*", "*://namadi11o.app/*", "*://namad1llo.app/*", "*://namad1ll0.app/*", "*://namad11lo.app/*", "*://namad111o.app/*", "*://namad1110.app/*", "*://nammadillo.app/*", "*://nammad1llo.app/*", "*://nammadi1lo.app/*", "*://nammadi11o.app/*", "*://nammadi110.app/*", "*://nammadill0.app/*", "*://nammadi1l0.app/*", "*://nammad1110.app/*" ] } ], }