feat: Updating SDK initialization #1
+12,242
−4,244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
2 times, most recently
from
9bdffd3 to
8c81462
Compare
jurevans
changed the title
jurevans
added
documentation
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
2 times, most recently
from
2dd3dc6 to
1281430
Compare
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
3 times, most recently
from
cd21d60 to
ab44d89
Compare
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
from
ab44d89 to
4cd0bb5
Compare
jurevans
commented
May 21, 2025
| @@ -169,7 +169,7 @@ mod tests { | |||
| #[wasm_bindgen_test] | |||
| fn can_verify_stored_hash() { | |||
| let password = "unhackable"; | |||
| let argon2 = Argon2::new(password.into(), None, None) | |||
| let argon2 = Argon2::new(password.into(), None, Some(Argon2Params::new(4096, 3, 1))) | |||
There was a problem hiding this comment.
default params in Argon2 lib have changed, so I made these explicit to pass
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
from
7156a7c to
5af54ba
Compare
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
from
3ab43b4 to
a62d569
Compare
2 tasks
jurevans
force-pushed
the
feat/refactor-wasm-loading
branch
from
5ea2c25 to
40eb173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this also incorporates changes from the following (since the opening of this PR):
After much experimenting and testing, and considering all of the variants of the SDK developers may require, I think we should split up the various target builds into separate published packages. The repo could look like the following:
The public packages having their own
package.jsonand implementation ofinitSdk()specific to the target will greatly simplify the packaging, as each published package will essentially be the same structure, only with the changes needed to support that particular build. Doing this means that developers only need to install one SDK build depending on their needs instead of all.Packages published to NPM
@namada/sdk@namada/sdk-multicore- I think with some craftiness this could be combined with the normal web SDK, however, it means we publish with two builds, and types would need to be refactored a bit to account for this. Might be more trouble than it's worth right now@namada/sdk-nodeSplitting these up will allow us to publish incrementally as each one is tested.