-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix to receive IBC denom when the base denom has slash #4643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yito88
wants to merge
24
commits into
main
Choose a base branch
from
yuji/fix-ibc-denom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
reviewed
May 19, 2025
sug0
approved these changes
May 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4643 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grarco
approved these changes
May 20, 2025
(cherry picked from commit ac02902)
(cherry picked from commit 768058b) # Conflicts: # .changelog/v101.1.0/miscellaneous/4680-v101.1.0-release.md # CHANGELOG.md
CI: bump maint version libs-v0.150 and apps-101.1 (backport #4682)
(cherry picked from commit bf2c10f)
(cherry picked from commit b9a882a)
(cherry picked from commit 7873448)
fix: remove redundant reads from governance vp (backport #4684)
Namada libs-v0.150.1 * tag 'libs-v0.150.1': Changelog: Release libs 0.150.1 Namada libs 0.150.1 changelog: #4684 fix: validate all the balance key changes fix: remove redundant reads from governance vp fix v101.1.0 changelog CI: bump maint version libs-v0.150 and apps-101.1
(cherry picked from commit 4904d21)
(cherry picked from commit 38af2f6)
Add custom multisig signature (backport #4695)
Namada libs-v0.150.2 release. * tag 'libs-v0.150.2': Changelog: Release libs 0.150.2 Namada libs 0.150.2 changelog: add #4695 Changed how multisig signatures are added to a tx
eb6bac4
to
82a371f
Compare
82a371f
to
9a3538a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:api
public API breaking change
breaking:consensus
Consensus breaking change that requires a hard-fork
bug
Something isn't working
IBC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Namada couldn't receive some tokes including
/
in the base denom, e.g.factory/stars16da2uus9zrsy83h23ur42v3lglg5rmyrpqnju4/dust
or Eureka tokentransfer/08-wasm-1369/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2
.is_ibc_denom
/
from the storage key of IBC traceChecklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo