Skip to content

Fix to receive IBC denom when the base denom has slash #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented May 19, 2025

Describe your changes

Namada couldn't receive some tokes including / in the base denom, e.g. factory/stars16da2uus9zrsy83h23ur42v3lglg5rmyrpqnju4/dust or Eureka token transfer/08-wasm-1369/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2.

  • Fixed to relax the condition in is_ibc_denom
  • Remove / from the storage key of IBC trace

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@yito88 yito88 requested a review from sug0 May 19, 2025 13:09
@yito88 yito88 added bug Something isn't working IBC labels May 19, 2025
@github-actions github-actions bot added the backport-libs-0.149 Backport libraries to 0.149 maintenance branch label May 19, 2025
@yito88 yito88 requested review from grarco and sug0 May 19, 2025 19:53
@sug0 sug0 added breaking:consensus Consensus breaking change that requires a hard-fork and removed backport-libs-0.149 Backport libraries to 0.149 maintenance branch labels May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c2cddf3) to head (def2c45).
Report is 20 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4643   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking:api public API breaking change label May 20, 2025
tzemanovic and others added 16 commits June 5, 2025 07:40
(cherry picked from commit 768058b)

# Conflicts:
#	.changelog/v101.1.0/miscellaneous/4680-v101.1.0-release.md
#	CHANGELOG.md
CI: bump maint version libs-v0.150 and apps-101.1 (backport #4682)
(cherry picked from commit 7873448)
fix: remove redundant reads from governance vp (backport #4684)
Namada libs-v0.150.1

* tag 'libs-v0.150.1':
  Changelog: Release libs 0.150.1
  Namada libs 0.150.1
  changelog: #4684
  fix: validate all the balance key changes
  fix: remove redundant reads from governance vp
  fix v101.1.0 changelog
  CI: bump maint version libs-v0.150 and apps-101.1
(cherry picked from commit 38af2f6)
Namada libs-v0.150.2 release.

* tag 'libs-v0.150.2':
  Changelog: Release libs 0.150.2
  Namada libs 0.150.2
  changelog: add #4695
  Changed how multisig signatures are added to a tx
@tzemanovic tzemanovic force-pushed the yuji/fix-ibc-denom branch 2 times, most recently from eb6bac4 to 82a371f Compare June 18, 2025 08:23
@tzemanovic tzemanovic force-pushed the yuji/fix-ibc-denom branch from 82a371f to 9a3538a Compare June 18, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:api public API breaking change breaking:consensus Consensus breaking change that requires a hard-fork bug Something isn't working IBC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants