-
Notifications
You must be signed in to change notification settings - Fork 43
[Documentation][2234]update_zos_replace_documentation #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Documentation][2234]update_zos_replace_documentation #2239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I recommended 3 large changes which might overlap with current PR comments, I can come back and do another review once we have incorporated all feedback. Thanks for working on this and providing a better user experience @AndreMarcel99
@@ -26,9 +26,17 @@ | |||
options: | |||
after: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are pending reviews, I can not multi select the entire section of text for after
so I am going to offer my rewrite that also updates the URL so there is no version embedded, also makes the latest Ansible markup O(...)
and other things like B(bold)
. This is for the entire after
section of text.
- A regular expression that if specified, determines which content will be replaced or removed B(after) the match.
- Option O(after) is the start position from where the module will seek to match the O(regexp) pattern. When a pattern is matched, occurrences are substituted with the value set for O(replace).
- If option O(after) is not set, the module will search from the beginning of the O(target).
- Option O(after) is a regular expression as described in the L(Python library,https://docs.python.org/3/library/re.html).
- Option O(after) can be used in combination with O(before). When combined with O(before), patterns are replaced or removed from O(after) until the value set for O(before).
- Option O(after) can be interpreted as a literal string instead of a regular expression by setting option I(literal=after).
@@ -63,9 +71,17 @@ | |||
type: str | |||
before: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are pending reviews, I can not multi select the entire section of text for before
so I am going to offer my rewrite that also updates the URL so there is no version embedded, also makes the latest Ansible markup O(...)
and other things like B(bold)
. This is for the entire before
section of text.
- A regular expression that if specified, determines which content will be replaced or removed B(before) the match.
- Option O(before) is the end position from where the module will seek to match the O(regexp) pattern. When a pattern is matched, occurrences are substituted with the value set for O(replace).
- If option O(before) is not set, the module will search to the end of the O(target).
- Option O(before) is a regular expression as described in the L(Python library,https://docs.python.org/3/library/re.html).
- Option O(before) can be used in combination with O(after). When combined with O(after), patterns are replaced or removed from O(after) until the value set for O(before).
- Option O(before) can be interpreted as a literal string instead of a regular expression by setting option I(literal=before).
@@ -81,7 +97,10 @@ | |||
literal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are pending reviews, I can not multi select the entire section of text for literal
so I am going to offer my rewrite that also updates the URL so there is no version embedded, also makes the latest Ansible markup O(...)
and other things like B(bold)
. This is for the entire literal
section of text.
- If specified, it enables the module to interpret options O(after), O(before) and O(regex) as a literal rather than a regular expression.
- Option O(literal) uses any combination of V(after), V(before) and V(regexp).
- To interpret one option as a literal, use O(literal=regexp), O(literal=after) or O(literal=before).
- To interpret multiple options as a literal, use a list such as C(['after', 'before']) or C(['regex', 'after', 'before'])
Co-authored-by: Alex Moreno <iamorenosoto@gmail.com>
Co-authored-by: Alex Moreno <iamorenosoto@gmail.com>
Co-authored-by: Alex Moreno <iamorenosoto@gmail.com>
I can't comment on this section because its not part of the DIFF for this PR, but this section needs some updates. From:
To:
|
SUMMARY
Update zos_replace documentation
Fixes #2234
ISSUE TYPE