Skip to content

fix: migrated (PR 4146): Set _post as a property so it's initialized when needed #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2025

Conversation

pyansys-ci-bot
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot commented Aug 5, 2025

This PR is a mirror pull request created from fix: Set _post as a property so it's initialized when needed to allow the code to access PyMAPDL CICD secrets.

Check the original PR made by @valallansys for more details.

Closes #4146

Original pull request

fix: Set _post as a property so it's initialized when needed

Description

We had an issue in mapdl using *PYT command which starts a python interpreter and imports mapdl as mapdlInProcess.
Then calling mapdl.dict led to a segmentation error because it called PostProcessing whithout results. We figured we didn't need to initialise _post unless needed

Issue linked

#4145

Checklist

@germa89 germa89 changed the title migrated (PR 4146): fix: Set _post as a property so it's initialized when needed fix: migrated (PR 4146): Set _post as a property so it's initialized when needed Aug 5, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (514cfae) to head (f5e2696).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4147   +/-   ##
=======================================
  Coverage   91.30%   91.31%           
=======================================
  Files         189      193    +4     
  Lines       15698    15724   +26     
=======================================
+ Hits        14333    14358   +25     
- Misses       1365     1366    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valallansys please can you have a look at this?

@germa89 germa89 merged commit 1876d75 into main Aug 8, 2025
48 checks passed
@germa89 germa89 deleted the migration/pr-4146 branch August 8, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants