-
Notifications
You must be signed in to change notification settings - Fork 139
fix: migrated (PR 4146): Set _post as a property so it's initialized when needed #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
germa89
approved these changes
Aug 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
=======================================
Coverage 91.30% 91.31%
=======================================
Files 189 193 +4
Lines 15698 15724 +26
=======================================
+ Hits 14333 14358 +25
- Misses 1365 1366 +1 🚀 New features to boost your workflow:
|
germa89
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valallansys please can you have a look at this?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mirror pull request created from fix: Set _post as a property so it's initialized when needed to allow the code to access PyMAPDL CICD secrets.
Check the original PR made by @valallansys for more details.
Closes #4146
Original pull request
fix: Set _post as a property so it's initialized when needed
Description
We had an issue in mapdl using *PYT command which starts a python interpreter and imports mapdl as mapdlInProcess.
Then calling mapdl.dict led to a segmentation error because it called PostProcessing whithout results. We figured we didn't need to initialise _post unless needed
Issue linked
#4145
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)