Annotate Node with line numbers from input XML #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Aufart <maufart@redhat.com>
|
Hello, @aufi , Thank you for your suggestion. To simplify the public API and reduce the number of methods, we could add a |
Signed-off-by: Marek Aufart <maufart@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use-case it was needed to run xpath query on the XML and be able to show relevant context of the match. The match could be just empty element with or without attributes, potentialy spanning over multiple lines, so some kind of grep of the source file with matched Node content was very fragile.
In order to provide reliable line numbers for matched nodes, the parser needed to be updated. As an addition to existing methods for parsing,
ParseWithLineNumbersandParseWithLineNumbersWithOptionswere added and their output provides Node with populated line numbers. Original behaviour should not be changed, just got line numbers with default 0.It would be great get this feature in, but I'm flexible on how to do that. I'm looking forward to feedback on reviews, thanks!