-
Notifications
You must be signed in to change notification settings - Fork 563
feat(i18n): add Spanish (es) translations for common.json #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add Spanish (es) translations for common.json #3182
Conversation
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated in latest commit
Removing blank line (no. 31) from LanguageMenu.tsx
vite.config.ts
Outdated
@@ -76,7 +76,7 @@ export default defineConfig({ | |||
semicolons: false, | |||
}), | |||
i18nProgress({ | |||
langs: ['en', 'de', 'zh'], | |||
langs: ['en','es', 'de', 'zh'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
langs: ['en','es', 'de', 'zh'], | |
langs: ['en', 'es', 'de', 'zh'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we should add more lint tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzp2010 Good point, I’ve updated the spacing as suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the code for any flaws, and all is well now. Since I do not speak Spanish, I am unable to check your i18n translations. Awaiting feedback from other maintainers or Spanish-speaking users.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This pull request adds Spanish (es) translations for
common.json
undersrc/locales/es/
.It also updates
src/config/i18n.ts
,vite.config.ts
, andLanguageMenu.tsx
to register Spanish language support.Now Spanish users can select and use the Dashboard in their native language.
Related issues
fix/resolve #1407
Checklist: