Skip to content

Conversation

ajinkya22-dev
Copy link
Contributor

@ajinkya22-dev ajinkya22-dev commented Aug 20, 2025

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This pull request adds Spanish (es) translations for common.json under src/locales/es/.
It also updates src/config/i18n.ts, vite.config.ts, and LanguageMenu.tsx to register Spanish language support.
Now Spanish users can select and use the Dashboard in their native language.

Related issues

fix/resolve #1407

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@yzeng25 yzeng25 requested a review from SkyeYoung August 27, 2025 01:06
};


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, updated in latest commit

Removing blank line (no. 31) from LanguageMenu.tsx
vite.config.ts Outdated
@@ -76,7 +76,7 @@ export default defineConfig({
semicolons: false,
}),
i18nProgress({
langs: ['en', 'de', 'zh'],
langs: ['en','es', 'de', 'zh'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
langs: ['en','es', 'de', 'zh'],
langs: ['en', 'es', 'de', 'zh'],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we should add more lint tools.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzp2010 Good point, I’ve updated the spacing as suggested

Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for any flaws, and all is well now. Since I do not speak Spanish, I am unable to check your i18n translations. Awaiting feedback from other maintainers or Spanish-speaking users.

@SkyeYoung SkyeYoung merged commit cf9444e into apache:master Aug 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for additional languages in the Dashboard
3 participants