-
Notifications
You must be signed in to change notification settings - Fork 356
chore: refactor provider #2507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor provider #2507
Conversation
Just a reminder: when marking this PR as ready for review, please fill in the description and checklist completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -89,7 +89,7 @@ jobs: | |||
|
|||
- name: Install And Run Cloud Provider KIND | |||
run: | | |||
go install sigs.k8s.io/cloud-provider-kind@latest | |||
go install sigs.k8s.io/cloud-provider-kind@v0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version is 0.7.0
, why can't we use latest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what go releases have done, it doesn't seem to make sense for us to be stuck with older versions, newer versions always include CVE security fixes and runtime improvements.
Maybe we should upgrade it in a later PR.
Type of change:
What this PR does / why we need it:
Description
This commit refactors the
adc
provider module with the goal of optimizing package structure, reducing module coupling, and improving code maintainability and extensibility.Changes include
internal/provider/adc
directory to a newinternal/adc
directory.cache
,client
, andtranslator
, with clearer responsibilities.configmanger
componentReason for the changes
adc
provider’s various functionalities were tightly coupled at the same level, making maintenance and extension costly.Pre-submission checklist: