-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-4110: Double Values Fail when using Min/Max #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This seems to be fixing the same bug as #3285 but in more methods. |
Agreed that there's overlap, but that I covered all the methods within PrimitivesArrays.DoubleArray. Also, I used the doubleValue instead of casting thus not using auto-boxing of the type thus ensuring the semantics of the following PR are followed: |
Now that #3285 has been merged, can this one be as well as it covers a wider set of use cases? |
@rdifrango Can you pull in the latest main? |
Done |
@KalleOlaviNiemitalo and/or @Fokko any update on getting this approved and merged? |
@rdifrango, this change looks OK to me but I don't trust my Java skills enough to formally approve. |
Any word on getting this merged as it completes the work that was started in #3285 |
Same class that seems to be related to this bug : https://issues.apache.org/jira/browse/AVRO-4125 When is this getting merged and released? |
@Fokko do you happen to have any objection against merging this fix? |
What is the purpose of the change
Resolves AVRO-4110
Double Values Fail when using Min/Max
Verifying this change
(Please pick one of the following options)
I added tests to
PrimitivesArraysTest
to cover the use case identified in the JIRA ticket.Documentation
Does this pull request introduce a new feature? (yes / no)
No
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)