AVRO-3989: [java] add conversion classes to default instance of SpecificData #3354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request improves deserialization of data when using default
SpecificData
instance.Why?
Often times,
SpecificDatumReader
andReflectDatumReader
are configured using the defaultSpecificData
instance. This leads to deserialization error when reading fields with union type and inner logical type (see test-case).Deserialization works correctly when using the custom
SpecificData
instance stored in theMODEL$
field of the schema class thatextends SpecificRecord
. The customSpecificData
has the necessary conversions stored to handle fields with union and logical types. The issue has been reported multiple times, notably in [AVRO-3989](linked JIRA).Verifying this change
This change added tests and can be verified as follows:
Documentation