AVRO-3731 [java/gradle-plugin] retry on any schema parse failure #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of the new SchemaParser in 1.12 the variety of errors which can be thrown when an unresolved type is found increased significantly. In the past unresolved type errors were tracked with a brittle regexp. In the newly proposed logic we propose to retry failed parse steps on any AvroRuntimeException. So this works for all past and future avro library versions.
steven-aerts
force-pushed
the
avro-3731-gradle-avro-plugin
branch
from
7fd07dd to
0e2f6a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the new SchemaParser in 1.12 the variety of errors which can be thrown when an unresolved type is found increased significantly.
In the past unresolved type errors were tracked with a brittle regexp. In the newly proposed logic we propose to retry failed parse steps on any AvroRuntimeException. So this works for all past and future avro library versions.
@frevib this is a small proposal for an update on #3305 so the gradle plugin support 1.12 and others.
Let me know what you think, and if I can help you improving it somehow.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
(or)
This change can be verified as follows:
SchemaResolverSpec.groovyDocumentation