Skip to content

Deserialize proto based (mutable key range) change stream return records #35408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

changliiu
Copy link
Contributor

@changliiu changliiu commented Jun 24, 2025

Parse proto type change stream return records into connector models.

Including:

  1. DataChangeRecord
  2. HeartbeatRecord
  3. PartitionStartRecord
  4. PartitionEndRecord
  5. PartitionEventRecord

Also:

  1. increase grpc java client lib version so that change stream new records e.g. PartitionStartRecords can be used.
  2. add unit tests for each type or records.

@changliiu changliiu force-pushed the v2-deserialization branch from 10e07a1 to 254762f Compare June 24, 2025 00:14
@changliiu changliiu marked this pull request as ready for review June 24, 2025 00:19
@changliiu changliiu force-pushed the v2-deserialization branch from 254762f to 71ddfe4 Compare June 24, 2025 00:36
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@changliiu changliiu force-pushed the v2-deserialization branch 2 times, most recently from 53081b9 to 458398f Compare June 24, 2025 20:45
Copy link
Contributor

@dedocibula dedocibula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments

@changliiu changliiu force-pushed the v2-deserialization branch 2 times, most recently from 684c368 to 52ebaac Compare June 25, 2025 18:16
pick 4d2a5a7 # Fix API surface test (apache#35028)

Deserialize change stream proto based (mutable key range) return types.
@changliiu changliiu force-pushed the v2-deserialization branch from 52ebaac to eff8905 Compare June 25, 2025 18:28
@changliiu
Copy link
Contributor Author

Friendly ping :)

@Abacn Abacn merged commit 3f3f214 into apache:master Jun 27, 2025
22 of 23 checks passed
@changliiu changliiu deleted the v2-deserialization branch June 27, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants