-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Deserialize proto based (mutable key range) change stream return records #35408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+601
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10e07a1
to
254762f
Compare
254762f
to
71ddfe4
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
53081b9
to
458398f
Compare
dedocibula
reviewed
Jun 25, 2025
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java
Outdated
Show resolved
Hide resolved
dedocibula
reviewed
Jun 25, 2025
...rc/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSet.java
Outdated
Show resolved
Hide resolved
dedocibula
reviewed
Jun 25, 2025
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java
Outdated
Show resolved
Hide resolved
dedocibula
reviewed
Jun 25, 2025
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java
Show resolved
Hide resolved
dedocibula
reviewed
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments
684c368
to
52ebaac
Compare
pick 4d2a5a7 # Fix API surface test (apache#35028) Deserialize change stream proto based (mutable key range) return types.
52ebaac
to
eff8905
Compare
Friendly ping :) |
thiagotnunes
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse proto type change stream return records into connector models.
Including:
Also: