Skip to content

Cloudpickle configurable #35422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

Conversation

claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Jun 24, 2025

Add the ability to override the default behavior of Cloudpickle by passing a CloudPickleConfig to cloudpickle.dumps.

The goal is to maintain default behavior, but add flexibility when different behavior is desired for example foregoing isinstance semantics for deterministic pickling of dynamic types.

This was copied from my cloudpickle fork https://github.com/claudevdm/cloudpickle/tree/cloudpickle-configurable, where I added unit test coverage for a bunch of different configurations and modified tests where appropriate.

I ran internal presubmit and tap for these changes and no issues found.

This is a prerequisite to relaxing dill pickler strict dependency #21298.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm force-pushed the cloudpickle-configurable branch from 8951c85 to 50b0059 Compare June 27, 2025 17:55
@claudevdm claudevdm marked this pull request as ready for review June 27, 2025 19:01
@claudevdm
Copy link
Collaborator Author

R: @tvalentyn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@tvalentyn tvalentyn merged commit 4d58e6d into apache:master Jun 27, 2025
100 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants