Arnav Arora BigTablePR #35435
Open
Arnav Arora BigTablePR #35435
+879
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connected and actually look good on user end for mutations
…hemaTransformProviderIT, and testing out new mutations etc
…ted new user input, all mutations work correctly, put demo code for it
derrickaw
reviewed
Jun 25, 2025
| @@ -420,32 +512,32 @@ def temp_oracle_database(): | |||
| yield f"jdbc:oracle:thin:system/oracle@localhost:{port}/XEPDB1" | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
There was a problem hiding this comment.
What kind of error are you seeing here? Thanks
derrickaw
reviewed
Jun 25, 2025
Comment on lines
47
to
49
| * <p><b>Internal only:</b> This class is actively being worked on, and it will likely change. We | ||
| * provide no backwards compatibility guarantees, and it should not be implemented outside the Beam | ||
| * repository. |
There was a problem hiding this comment.
is this needed anymore?
derrickaw
reviewed
Jun 25, 2025
...ain/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
derrickaw
reviewed
Jun 25, 2025
...ain/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
derrickaw
reviewed
Jun 25, 2025
...ain/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
derrickaw
reviewed
Jun 25, 2025
...t/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProviderIT.java
Outdated
Show resolved
Hide resolved
…am/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java Co-authored-by: Derrick Williams <myutat@gmail.com>
…am/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java Co-authored-by: Derrick Williams <myutat@gmail.com>
…am/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java Co-authored-by: Derrick Williams <myutat@gmail.com>
derrickaw
reviewed
Jun 25, 2025
| // we created two rows then deleted one, so should end up with the row we didn't touch | ||
| assertEquals(1, rows.size()); | ||
| assertEquals("key-2", rows.get(0).getKey().toStringUtf8()); | ||
| } |
There was a problem hiding this comment.
can we add one more test where it does all the mutation flavors?
derrickaw
reviewed
Jun 25, 2025
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| # Protect against environments where bigtable library is not available. |
There was a problem hiding this comment.
Have you seen this in your environment?
derrickaw
reviewed
Jun 25, 2025
derrickaw
reviewed
Jun 25, 2025
derrickaw
reviewed
Jun 25, 2025
...ain/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
|
Seems like many of those precommit checks have valid errors to clean up. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…am/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProvider.java Co-authored-by: Derrick Williams <myutat@gmail.com>
…am/sdk/io/gcp/bigtable/BigtableSimpleWriteSchemaTransformProviderIT.java Co-authored-by: Derrick Williams <myutat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@damccorm @derrickaw @fozzie15 @ahmedabu98
I added the BigTable Connector for BeamYaml
added a "buffer" class for bigtable yaml where you can simplify the user input and make it more readable than the old logic,
all mutations work correctly but waiting for this issue to be solved
added tests to integration_test.py (I commented out some bugs in integration_test.py from new commits on the main branch, will remove if no more errors)
all logic works, please let me know if anything looks off/funny and if anything can be improved
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.