-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix paths to images #4333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Fix paths to images #4333
Conversation
Signed-off-by: Nikita Eshkeev <kastolom@gmail.com>
Could anyone, please, take a look at the PR? It would be great if the documentation could properly render the images |
multiplicity of the connection. | ||
|
||
image::data_modeling_hotel_erd.png[image] | ||
image::images/data_modeling_hotel_erd.png[image] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I view this file in IDEA, image::data_modeling_hotel_erd.png[image]
just displays the image correctly.
Why should we rework this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed images/
, then I generated HTML once again, but no pictures got rendered on the pages. So I believe images/
cannot be omitted, apparently IDEA uses some alternative way to render pictures
I used the asciidoctor
command from the first message, please tell me if this project executes a different command to generate documentation
logical data model. | ||
|
||
image::cassandra:developing/data-modeling/data_modeling_chebotko_logical.png[image] | ||
image::images/data_modeling_chebotko_logical.png[image] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is broken in IDEA when viewing there, this displays it:
image::data_modeling_chebotko_logical.png[image]
Same approach as above. We do not need images/
I will be covering more documentation issues closer to the release we are so please don't feel to be overlooked when there is not any activity on this so far. I am just tagging everything with "docs" label to see them all. |
I noticed that the images in the documentation are not rendered properly, so I fixed the paths in the images links.
I tested if the images are rendered correctly locally with the following command, please tell me if the command is not correct: