strict_mv_consistency implementation #4358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // When false, it behaves the same as normal streaming. | ||
| public volatile boolean materialized_views_on_repair_enabled = true; | ||
|
|
||
| public boolean materialized_view_base_table_metric_collection_enabled = false; |
There was a problem hiding this comment.
add this new configurations to config/cassandra_latest.yaml
|
|
||
| for (ModificationStatement statement : statements) | ||
| { | ||
| if (DatabaseDescriptor.getMaterializedViewsBasetableMetricCollectionEnabled()) |
There was a problem hiding this comment.
These four lines are redundant at multiple places. I think it would be a good idea to create a wrapper for it.
| SinglePartitionReadCommand readCommand = null; | ||
| if (isAcceptedButNotCommitted && table.strictMVEnabled() && !latestAccepted.update.isEmpty()) | ||
| { | ||
| assert latestAccepted.update.rowCount() == 1 : "latest accepted with multiple rows: " + latestAccepted.update.rowCount(); |
There was a problem hiding this comment.
Is this assertion even feasible in everyday situations? Or possible in case of bugs only?
There was a problem hiding this comment.
It is possible in case of bugs only.
| } | ||
| } | ||
|
|
||
| public static void getCurrentAndApplyMVMutations(SinglePartitionReadCommand query, |
There was a problem hiding this comment.
nit; should we name this to something like, resolveCurrentAndApplyMVMutations, because "get" might confuse the people in that they would assume that it is doing a read RPC to get the current state, which is not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for strict_mv_consistency that move MV base table update backed by LWT (Paxos V2).
It contains following changes:
The Cassandra Jira