Implement Shard and CoordinatorLog metadata durability #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aratno
approved these changes
Sep 8, 2025
src/java/org/apache/cassandra/replication/MutationTrackingService.java
Outdated
Show resolved
Hide resolved
| localWitnessed = Offsets.Mutable.copy(witnessedOffsets.get(localNodeId)); | ||
|
|
||
| witnessedOffsets.convertToPrimitiveMap(witnessed); | ||
| persistedOffsets.convertToPrimitiveMap(persisted); |
There was a problem hiding this comment.
Would be good to make this incremental in the future, since every witnessed offset will eventually be persisted and reconciled
There was a problem hiding this comment.
I'm not sure about this one. We must overwrite the entire value of each list in the system table because of the representation, but that shouldn't be a big deal - the size of each list should be roughly the same - the head, with not gaps, collapsed into one range, plus the slightly sparse tail. I don't see how to make it incremental in this context, or what it'd bring. I could easily be missing something though.
patch by Aleksey Yeschenko; reviewed by Abe Ratnofsky for CASSANDRA-20882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Aleksey Yeschenko; reviewed by Abe Ratnofsky for CASSANDRA-20882