Skip to content

Conversation

shwstppr
Copy link
Contributor

Description

Related #11705

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…ownership selection

Related apache#11705

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.43%. Comparing base (8089d32) to head (84795f1).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11706      +/-   ##
============================================
+ Coverage     17.36%   17.43%   +0.06%     
- Complexity    15245    15341      +96     
============================================
  Files          5888     5892       +4     
  Lines        525831   526534     +703     
  Branches      64183    64296     +113     
============================================
+ Hits          91298    91779     +481     
- Misses       424227   424399     +172     
- Partials      10306    10356      +50     
Flag Coverage Δ
uitests 3.61% <ø> (-0.02%) ⬇️
unittests 18.48% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-761)

@shwstppr shwstppr marked this pull request as ready for review September 24, 2025 14:45
@DaanHoogland
Copy link
Contributor

@shwstppr , why not put these in the same PR with #11705 ? The changes in OwnershipSelection.vue seems exactly the same?

@shwstppr
Copy link
Contributor Author

@DaanHoogland because DeployVMFromBackup is not present in 4.20 for which #11705 is targeted

@DaanHoogland
Copy link
Contributor

Cool, so the changes in OwnershipSelection.vue will be the merge forward conflict. Of which notice!

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Sep 25, 2025
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-763)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-765)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants