-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection #11706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection #11706
Conversation
…ownership selection Related apache#11705 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11706 +/- ##
============================================
+ Coverage 17.36% 17.43% +0.06%
- Complexity 15245 15341 +96
============================================
Files 5888 5892 +4
Lines 525831 526534 +703
Branches 64183 64296 +113
============================================
+ Hits 91298 91779 +481
- Misses 424227 424399 +172
- Partials 10306 10356 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@DaanHoogland because DeployVMFromBackup is not present in 4.20 for which #11705 is targeted |
Cool, so the changes in OwnershipSelection.vue will be the merge forward conflict. Of which notice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Description
Related #11705
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?