-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix detection of Mi3xx GPUs #11715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix detection of Mi3xx GPUs #11715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the detection of AMD Mi3xx GPUs by updating the PCI class filtering logic in the GPU discovery script. The issue was that Mi3xx GPUs have a PCI class of "Processing accelerators" rather than "3D controller", causing them to be filtered out during GPU detection.
- Updates the PCI class regex pattern to include "Processing accelerators" alongside "3D controller"
- Adds comprehensive documentation example showing expected output for Mi325X GPU
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested the script locally with my Nvidia GPU and the script is not throwing any errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11715 +/- ##
============================================
+ Coverage 17.39% 17.42% +0.03%
- Complexity 15284 15335 +51
============================================
Files 5891 5892 +1
Lines 526290 526521 +231
Branches 64257 64293 +36
============================================
+ Hits 91543 91762 +219
- Misses 424401 424407 +6
- Partials 10346 10352 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@dk-blackfuel Are you able to use it inside a VM? This might require changes in LibvirtGPUDef.java. |
Description
This PR addresses Issue with parsing the lspci output to detect AMD Mi3xx GPUs and make them available for use in cloudstack.
Fixes: #11701
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
On an Mi325X server, the bash script was launched and the output matches the expected output described in the issue.
Also, in cloudstack 4.21, with the modified script version, the GPUs are listed as expected :
