Shared Filesystem support on Config Drive Networks

[abh1sar]

Description

This PR fixes #10315

This will require a new systemvmtemplate.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before fix on config drive :

After fix on config drive :

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.42%. Comparing base (8eb6ddd) to head (63aaf2b).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11726      +/-   ##
============================================
+ Coverage     17.39%   17.42%   +0.02%     
- Complexity    15285    15333      +48     
============================================
  Files          5889     5892       +3     
  Lines        526183   526521     +338     
  Branches      64242    64293      +51     
============================================
+ Hits          91542    91757     +215     
- Misses       424297   424410     +113     
- Partials      10344    10354      +10     

Flag	Coverage Δ
uitests	3.61% <ø> (-0.01%)	⬇️
unittests	18.47% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

code lgtm

[weizhouapache]

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

[abh1sar]

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

Yes, @weizhouapache

[weizhouapache]

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

Yes, @weizhouapache

good @abh1sar

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15171

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14441)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11726-t14441-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[vishesh92]

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

[weizhouapache]

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

[vishesh92]

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.

[weizhouapache]

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

[vishesh92]

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

Yes. We will need to do that.

[weizhouapache]

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

Yes. We will need to do that.

maybe after merge of #11654 ?