CKS: fix CKS creation on an existing Shared or Routed network

[weizhouapache]

Description

This PR fixes a regression of #11528

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.43%. Comparing base (36cfd76) to head (a954dbf).
⚠️ Report is 7 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11735      +/-   ##
============================================
+ Coverage     16.17%   17.43%   +1.25%     
- Complexity    13296    15341    +2045     
============================================
  Files          5656     5892     +236     
  Lines        498219   526528   +28309     
  Branches      60451    64294    +3843     
============================================
+ Hits          80579    91785   +11206     
- Misses       408672   424388   +15716     
- Partials       8968    10355    +1387     

Flag	Coverage Δ
uitests	3.61% <ø> (-0.40%)	⬇️
unittests	18.48% <0.00%> (+1.45%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15182

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15184

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-14450)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53352 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11735-t14450-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

@Pearl1594
could you test this PR if you have time ?

[vishesh92]

I am testing this PR.

[blueorangutan]

[SF] Trillian Build Failed (tid-14512)

[vishesh92]

Before this change, the creation of CKS cluster in a shared network failed with the below error:

I also verified that issue didn't exist in 4.20.1. After this change, I am able to create CKS clusters in the shared network.

[vishesh92]

lgtm