Skip to content

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Sep 26, 2025

Description

This PR moves the Backup Repository to Infrastructure section (from Configuration). Also, updated listInfrastructure API to return backuprepositories in response.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Check the Infrastructure section in the UI. listInfrastructure API returns backuprepositories in response.

BEFORE Changes =>

Before_BackupRepository_Configuration

AFTER Changes =>

After_BackupRepository_InfrastructureSummary After_BackupRepository_Infrastructure
(cmk) 🐱 > list infrastructure 
{
  "infrastructure": {
    "alerts": 12,
    "backuprepositories": 2,
    "clusters": 1,
    "cpusockets": 3,
    "hosts": 1,
    "ilbvms": 0,
    "imagestores": 1,
    "managementservers": 1,
    "objectstores": 0,
    "pods": 1,
    "routers": 1,
    "storagepools": 2,
    "systemvms": 3,
    "zones": 1
  }
}
(cmk) 🐱 > 

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.42%. Comparing base (ec533cd) to head (f93cb1e).

Files with missing lines Patch % Lines
...he/cloudstack/response/InfrastructureResponse.java 0.00% 3 Missing ⚠️
.../apache/cloudstack/metrics/MetricsServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11738   +/-   ##
=========================================
  Coverage     17.42%   17.42%           
- Complexity    15336    15338    +2     
=========================================
  Files          5892     5893    +1     
  Lines        526521   526526    +5     
  Branches      64293    64294    +1     
=========================================
+ Hits          91767    91769    +2     
- Misses       424401   424404    +3     
  Partials      10353    10353           
Flag Coverage Δ
uitests 3.61% <ø> (-0.01%) ⬇️
unittests 18.48% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti marked this pull request as ready for review September 26, 2025 11:31
@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15186

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15189

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14457)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54978 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11738-t14457-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_L2_persistent_network Failure 102.23 test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist Failure 126.11 test_persistent_network.py

Copy link

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants