noVNC: make show dot configurable

[vishesh92]

Description

This PR makes show_dot configurable for noVNC.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Copilot]

Pull Request Overview

This PR makes the noVNC console "show_dot" parameter configurable through a new zone-scoped configuration key, allowing administrators to control whether the dot cursor is displayed in noVNC consoles when no local cursor is provided by the remote server.

• Introduces a new configurable parameter NoVncConsoleShowDot with zone-level scope
• Updates console URL generation to use the configurable value instead of hardcoded "true"
• Registers the new configuration key in the console proxy manager

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
ConsoleProxyManager.java	Defines the new NoVncConsoleShowDot configuration key with zone scope
ConsoleProxyManagerImpl.java	Registers the new configuration key in the config keys array
ConsoleAccessManagerImpl.java	Updates URL generation to use the configurable show_dot value instead of hardcoded "true"

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.50%. Comparing base (2c1aad4) to head (467f49c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...udstack/consoleproxy/ConsoleAccessManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11741   +/-   ##
=========================================
  Coverage     17.50%   17.50%           
  Complexity    15427    15427           
=========================================
  Files          5894     5894           
  Lines        526845   526847    +2     
  Branches      64334    64335    +1     
=========================================
+ Hits          92232    92233    +1     
- Misses       424236   424237    +1     
  Partials      10377    10377           

Flag	Coverage Δ
uitests	3.61% <ø> (ø)
unittests	18.56% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@vishesh92
is there any issue when showdot is true ?

[vishesh92]

@vishesh92 is there any issue when showdot is true ?

@weizhouapache no issue. Just making it configurable for users who don't want this.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15195

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15205

[vishesh92]

@blueorangutan test keepEnv

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14461)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52032 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11741-t14461-kvm-ol8.zip
Smoke tests completed. 144 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	Error	0.00	test_cluster_drs.py
test_list_system_vms_metrics_history	Failure	0.23	test_metrics_api.py
test_01_deployVMInSharedNetwork	Failure	338.97	test_network.py

[rohityadavcloud]

LGTM, didn’t test it

[weizhouapache]

code lgtm

[weizhouapache]

showdot=false

showdot=true