Skip to content

fix that log sensitive infomation in cmd of script #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 4.20
Choose a base branch
from
Open

fix that log sensitive infomation in cmd of script #12024

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5bae182
fix that log sensitive infomation in cmd of script
Nov 8, 2025
f9a05f5
Remove unnecessary line break in Script.java
YLChen-007 Nov 8, 2025
7dc5b2b
Update utils/src/main/java/com/cloud/utils/script/Script.java
YLChen-007 Nov 11, 2025
d15379b
Refactor logging in Script class to simplify handling of sensitive ar…
Nov 11, 2025
30fed1a
Merge branch 'my-fix-420-mask-script-cmd-sensitive-info' of https://g…
Nov 11, 2025
64a6547
Improve command logging in Script class to include full command line …
Nov 11, 2025
a617571
Remove unused _passwordCommand flag from Script class to simplify code
Nov 12, 2025
2468400
Update utils/src/main/java/com/cloud/utils/script/Script.java
YLChen-007 Nov 12, 2025
45a66f0
Remove unused import for KeyStoreUtils
YLChen-007 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...va/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUpdateHostPasswordCommandWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public Answer execute(final UpdateHostPasswordCommand command, final LibvirtComp
final String newPassword = command.getNewPassword();

final Script script = libvirtUtilitiesHelper.buildScript(libvirtComputingResource.getUpdateHostPasswdPath());
script.add(username, newPassword);
script.add(username);
script.addSensitive(newPassword);
final String result = script.execute();

if (result != null) {
Expand Down
5 changes: 3 additions & 2 deletions ...hypervisor/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,10 @@ public Answer execute(final UpdateHostPasswordCommand command, final CitrixResou

Pair<Boolean, String> result;
try {
logger.debug("Executing command in Host: " + cmdLine);
logger.debug("Executing command in Host: " + xenServerUtilitiesHelper.buildCommandLine(SCRIPT_CMD_PATH,
VRScripts.UPDATE_HOST_PASSWD, username, "******"));
final String hostPassword = citrixResourceBase.getPwdFromQueue();
result = xenServerUtilitiesHelper.executeSshWrapper(hostIp, 22, username, null, hostPassword, cmdLine.toString());
result = xenServerUtilitiesHelper.executeSshWrapper(hostIp, 22, username, null, hostPassword, cmdLine);
} catch (final Exception e) {
return new Answer(command, false, e.getMessage());
}
Expand Down
Loading
Loading