Skip to content

Conversation

AHeise
Copy link
Contributor

@AHeise AHeise commented Oct 14, 2025

What is the purpose of the change

To take a checkpoint, UC ITs relied on a limited number of retries after failing artificially to produce a checkpoint with in-flight data. Naturally, this approach is flaky when the actual test environment is flaky and retry attempts are used up quickly for unplanned restarts.

The solution is to stop fiddling around with the number of retries and instead use NonRecoverableError to force a failure of the job independent of the retries.

This commit also switches to a better way to retrieve the path of that checkpoint (through JobManager API).

Brief change log

  • Improves stability of UnalignedCheckpoint ITs

Verifying this change

Test only change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

To take a checkpoint, UC ITs relied on a limited number of retries after failing artificially to produce a checkpoint with in-flight data. Naturally, this approach is flaky when the actual test environment is flaky and retry attempts are used up quickly for unplanned restarts.

The solution is to stop fiddling around with the number of retries and instead use NonRecoverableError to force a failure of the job independent of the retries.

This commit also switches to a better way to retrieve the path of that checkpoint (through JobManager API).
Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@AHeise AHeise merged commit c7d683c into apache:master Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants