Skip to content

Conversation

sapienza88
Copy link
Contributor

This open PR is for updating the docs for newly implemented graph features (graph vertex and edge removal) in Java

@sapienza88
Copy link
Contributor Author

@yangxk1 pls proceed to reviewing my past PRs

@yangxk1
Copy link
Contributor

yangxk1 commented Jul 14, 2025

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

@sapienza88
Copy link
Contributor Author

sapienza88 commented Jul 14, 2025

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

@yangxk1
Copy link
Contributor

yangxk1 commented Jul 14, 2025

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

For example, the following ci:

https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711

https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714

@sapienza88
Copy link
Contributor Author

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

For example, the following ci:

https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711

https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714

These come after reviewing the code! (as a matter of fact these are formatting related issues easily solved with spotless:apply of maven.

@yangxk1
Copy link
Contributor

yangxk1 commented Jul 14, 2025

rerun mvn spotless:apply and push to your branch, ci will be triggered again :)

@sapienza88
Copy link
Contributor Author

sapienza88 commented Jul 14, 2025

rerun mvn spotless:apply and push to your branch, ci will be triggered again :)

I will do that but pls review the other PRs as well so we can merge them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants