JAMES-3340 JMAP thread collapse option for Email/query #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with EmailQueryView
Arsnael
commented
Sep 3, 2025
| public Flux<MessageId> listMailboxContentSortedBySentAt(MailboxId mailboxId, Limit limit, boolean collapseThreads) { | ||
| Preconditions.checkArgument(!limit.isUnlimited(), "Limit should be defined"); | ||
|
|
||
| Limit limitFetch = defineLimitFetch(limit, collapseThreads); |
There was a problem hiding this comment.
Cassandra is defo trickier :)
I'm not sure here...
I've been thinking quite a lot, this is a proposition among others. I feel like looping on cassandra requests until we meet the limit for collapseThreads would complexify greatly the code and for not such a great gain (more costly in perf too).
I thought:
- or we do like some requests that need to be post-sorted, just fetch all records, then collapsing threads and take the limit
- or we fetch an upper limit (here 3 times the limit defined) and we collapse threads and then take up to the limit. We accept that maybe sometimes we could have a bit less than the limit (hopefully rare enough) but it should stay balanced in terms of perf and keep the code relatively simple.
I tried to look at paging too but that would complexify a lot the code as well I believe (like looping).
Well brain storming welcomed honestly
There was a problem hiding this comment.
I can get a try to the cassandra implem but yes we would need some extra work for Cassandra.
However can we focus on the short term on SaaS related topis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still left Cassandra and Postgresql implem finalizing