MINOR: Change LogCompactionTester topics parameter to Set<String> #20372
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test log |
Yunyung
reviewed
Aug 19, 2025
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java
Outdated
Show resolved
Hide resolved
m1a2st
reviewed
Aug 19, 2025
Comment on lines
+251
to
+253
| Set<String> topics = IntStream.range(0, topicCount) | ||
| .mapToObj(i -> "log-cleaner-test-" + testId + "-" + i) | ||
| .toArray(String[]::new); | ||
| .collect(toCollection(LinkedHashSet::new)); |
There was a problem hiding this comment.
Why don’t we use a List? I think a List is more convenient than a Set when we need to retrieve elements.
There was a problem hiding this comment.
@m1a2st thanks for the review! I totally agree with List would be more convenient for indexed access, but Set is preferred here because
- semantic clarity:
topicsrepresents a collection of unique topic names - duplicate prevention:
Setprotects against duplicate topics by accident
brandboat
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
LGTM, e2e test result seems good.
[INFO:2025-08-18 18:18:23,475]: starting test run with session id 2025-08-18--002...
[INFO:2025-08-18 18:18:23,475]: running 1 tests...
[INFO:2025-08-18 18:18:23,475]: Triggering test 1 of 1...
[INFO:2025-08-18 18:18:23,480]: RunnerClient: Loading test {'directory': '/opt/kafka-dev/tests/kafkatest/tests/tools', 'file_name': 'log_compaction_test.py', 'cls_name': 'LogCompactionTest', 'method_name': 'test_log_compaction', 'injected_args': {'metadata_quorum': 'ISOLATED_KRAFT'}}
[INFO:2025-08-18 18:18:23,481]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: on run 1/1
[INFO:2025-08-18 18:18:23,482]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Setting up...
[INFO:2025-08-18 18:18:23,482]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Running...
[INFO:2025-08-18 18:19:13,711]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Tearing down...
[INFO:2025-08-18 18:19:18,607]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: PASS
[WARNING - 2025-08-18 18:19:18,607 - runner_client - log - lineno:459]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Test requested 4 nodes, used only 3
[WARNING:2025-08-18 18:19:18,607]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Test requested 4 nodes, used only 3
[INFO:2025-08-18 18:19:18,608]: RunnerClient: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT: Data: None
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id: 2025-08-18--002
run time: 55.240 seconds
tests run: 1
passed: 1
flaky: 0
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT
status: PASS
run time: 55.126 seconds
--------------------------------------------------------------------------------
DL1231
approved these changes
Aug 21, 2025
chia7712
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #19905 (comment)
What: Change
String[] topicstoSet<String> topicsthroughoutLogCompactionTester. Why:Set<String>is more modern and reduces theneed for array-to-collection conversions.
Reviewers: Ken Huang s7133700@gmail.com, TengYao Chi
kitingiao@gmail.com, Jhen-Yung Hsu jhenyunghsu@gmail.com, Lan Ding
isDing_L@163.com, Kuan-Po Tseng brandboat@gmail.com, Chia-Ping
Tsai chia7712@gmail.com