-
Notifications
You must be signed in to change notification settings - Fork 14.6k
KAFKA-19618: the record-size
and throughput
arguments don't work in TestRaftServer
#20379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in TestRaftServer
Some benchmark for reference: Default throughput and record-size
Throughput = 20000
record-size = 512
|
record-size
and throughput
arguments don't work in TestRaftServerrecord-size
and throughput
arguments don't work in TestRaftServer
chia7712
reviewed
Aug 20, 2025
@@ -428,7 +428,7 @@ object TestRaftServer extends Logging { | |||
} | |||
|
|||
private class TestRaftServerOptions(args: Array[String]) extends CommandDefaultOptions(args) { | |||
val configOpt: OptionSpec[String] = parser.accepts("config", "Required configured file") | |||
val configOpt: OptionSpec[String] = parser.accepts("config", "REQUIRED: The configured file") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use CommandLineUtils.checkRequiredArgs
to check the existence in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks.
Verification:
$ bin/test-kraft-server-start.sh
[2025-08-21 00:41:04,035] INFO Registered `kafka:type=kafka.Log4jController` MBean (kafka.utils.Log4jControllerRegistration$)
Standalone raft server for performance testing
Option Description
------ -----------
--config <String: filename> REQUIRED: The configured file
--help Print usage information.
--record-size <Integer: size in bytes> The size of each record (default: 256)
--replica-directory-id <String: REQUIRED: The directory id of the
directory id> replica
--throughput <Integer: records/sec> The number of records per second the
leader will write to the metadata
topic (default: 5000)
--version Display Kafka version.
$ bin/test-kraft-server-start.sh --config config/kraft.properties
[2025-08-21 00:41:12,627] INFO Registered `kafka:type=kafka.Log4jController` MBean (kafka.utils.Log4jControllerRegistration$)
Missing required argument "[replica-directory-id]"
Option Description
------ -----------
--config <String: filename> REQUIRED: The configured file
--help Print usage information.
--record-size <Integer: size in bytes> The size of each record (default: 256)
--replica-directory-id <String: REQUIRED: The directory id of the
directory id> replica
--throughput <Integer: records/sec> The number of records per second the
leader will write to the metadata
topic (default: 5000)
--version Display Kafka version.
$ bin/test-kraft-server-start.sh --replica-directory-id b8tRS7h4TJ2Vt43Dp85v2A
[2025-08-21 00:41:22,486] INFO Registered `kafka:type=kafka.Log4jController` MBean (kafka.utils.Log4jControllerRegistration$)
Missing required argument "[config]"
Option Description
------ -----------
--config <String: filename> REQUIRED: The configured file
--help Print usage information.
--record-size <Integer: size in bytes> The size of each record (default: 256)
--replica-directory-id <String: REQUIRED: The directory id of the
directory id> replica
--throughput <Integer: records/sec> The number of records per second the
leader will write to the metadata
topic (default: 5000)
--version Display Kafka version.
chia7712
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
record-size
andthroughput
arguments don’t work inTestRaftServer
. TherecordsPerSec
andrecordSize
values are alwayshard-coded.
recordsPerSec
andrecordSize
values hard-coded issueusers.
Reviewers: Chia-Ping Tsai chia7712@gmail.com